LocalIP is not an IP address in discover request

[gtb]

While I do not think this is an officially sanctioned API (from the github docs), making a request to http://my.hdhomerun.com/discover returns a json object useful to determine the local devices. Included is the local IP address. However, for Storage Engines, the LocalIP is not an IP address, but the IP address with the port. The port is available (and of course necessary for a Storage Engine) in the BaseURL and the DiscoverURL. It should not be in the LocalIP. Please consider making the LocalIP actually be a valid IP. Thanks for your consideration.

Sample response below including tuner (LocalIP is an IP address) and a storage engine (LocalIP includes port) [FD: this list was edited to change device ids and ip addresses, so it might not be completely valid]

Code: Select all

[
    {
        "DeviceID": "11111111",
        "LocalIP": "10.0.1.10",
        "BaseURL": "http://10.0.1.10:80",
        "DiscoverURL": "http://10.0.1.10:80/discover.json",
        "LineupURL": "http://10.0.1.10:80/lineup.json"
    },
    {
        "StorageID": "11111111-1111-1111-1111-111111111111",
        "LocalIP": "10.0.0.11:4999",
        "BaseURL": "http://10.0.1.11:4999",
        "DiscoverURL": "http://10.0.1.11:4999/discover.json",
        "StorageURL": "http://10.0.1.11:4999/recorded_files.json"
    }
]

[signcarver]

I would disagree here as some may decide to base their requests off such address(and not bother with base/discover/storage url etc and manually add what is needed. Over 99% of recording engines would need the port number to access them... in other words i feel the opposite and that all the others need not be there (though i guess i wouldn't mind just base)

[MatthewLundberg]

Seems that they might be consistent about the values returned. The tuner devices don't return the port in that field.

[gtb]

I would disagree here ...

I guess I believe the Internets RFCs definition of what an IP address is should take precedence (using the presumption that something named "LocalIP" means it is an IP address), but I will absolutely agree that SD can choose to ignore standards.

[signcarver]

What I believed happened was originally only that field (LocalIP) was returned (this may have been going back to the samsung e series tv app) and as a result any "older" software that may have used it may have needed it for compatibility (but these probably never would support storage engines)